Place the correct program and arguments into RunProgramError #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test macOS |
plemarquand
approved these changes
May 9, 2025
patricktcoakley
pushed a commit
to patricktcoakley/swiftly
that referenced
this pull request
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When runProgramOutput produces an error the exit code, program
name, and arguments are captured in a RunProgramError. However,
the program is being set to the first argument instead of the program
name, and the arguments doesn't include that first argument.
Correctly set the program name to the be the program name, and
set the arguments to be the entire argument list so that the error is
clear, and has all of the details.